Source Code Review Form 
=======================
(version 1.3)

Date: 2007-01-19

1 Identification
PJ-2007-01-19-0: RFE:       Evaluation Expression Support.
                 Issue:     56
                 Bugster:   6205203,5101053,5101735
                 Review:    AH
                 
2 Conforms to specification

2 [x] yes
2 [ ] no - comment:


3 Documentation

3.1 user/admin guide OK, or doc CR filed?
3.1 [ ] yes
3.1 [x] no - comment: No, there is need to explain a new expression term, and
according to https://n1wiki.sfbay.sun.com/bin/view/GEPRIVATE/N1GridEngineEngineeringImprovedEvalExpression#Documentation changes
document change description of several command arguments.

3.2 man pages (user view) correct?
3.2 [x] yes
3.2 [ ] no - comment: I did changes in sge_types(1), complexes(1), and minor changes in other described in document above and
these changes needs to be corrected by native corrector.

3.3 -help output correct and complete?
3.3 [x] yes
3.3 [x] no - comment: No additional options there

3.4 documented interfaces (at least GDI, EVI, libs, ADOC format) correct, updated?
3.4 [x] yes
3.4 [ ] no - comment:

3.5 messages, output formats and defines OK?
3.5 [x] yes
3.5 [ ] no - comment: I introduce several new messages

3.6 Bugster CR complete and correct?
3.6 [x] yes
3.6 [ ] no - comment: 

3.7 Issuezilla entry (if exists) complete and correct?
3.7 [x] yes
3.7 [ ] no - comment: 

4 Source review

4.1 Style guide conformance
4.1 [x] yes
4.1 [ ] no - comment:

4.2 Memory leaks
4.2 [x] yes
4.2 [ ] no - comment:

4.3 Thread safe
4.3 [x] yes
4.3 [ ] no


5 Tests

5.1 Used memory leak debugger
5.1 [ ] yes
5.1 [x] no - comment: n/a

5.2 Manual tests
Description:
Tests for the sge_eval_expression support
Test successfull:
5.2 [x] yes
5.2 [ ] no - comment:

5.3 Testsuite covers issue
5.3 [x] yes
5.3 [ ] no - comment: 

5.4 If 5.3 = no: New testsuite tests or module test created?
5.4 [x] yes, path: module_tests/generic
5.4 [ ] no - justification: 

5.5 If 5.4 = no: Testsuite issue created?
5.5 [ ] yes, id: 
5.5 [x] no - justification: All solve all issues before I did the review

5.6 Testsuite run successfull
5.6 [x] yes - The module tests
5.6 [ ] no - comment:


6 Comments


7 Accepted
7 [x] yes
7 [ ] no - comment: