Source Code Review Form 
=======================
(version 1.3)

Date: 2008-07-04

1 Identification
LP-2008-07-04-0: Enhancem:  Windows host list is now saved during the backup for
                            upgrade procedure
                 Enhancem:  SGE_CELL, SGE_CLUSTER_NAME, PRODUCT_MODE is used 
                            from the backup during the upgrade
                 Enhancem:  Added post update actions to clean execd_spool_dirs,
                            remove RC scripts, create RC scripts, update WINSVC
                 Enhancem:  WINSVC install no longer reinstalls a service 
                            (winupdate should be used)
                 Cleanup:   Various upgrade/install code
                 Bugfix:    JMX java detection fixed
                 Bugfix:    Upgrade script failed when choosing a different 
                            port number then $SGE_QMASTER_PORT
                 Bugfix:    upgrade does not create arusers user set
                 Bugfix:    upgrade does not save host_aliases file
                 Bugfix:    upgrade does not create display_win_gui complex
                 Bugfix:    Auto install template value checking is too strict 
                            on COPY_COMMAND
                 Bugfix:    qmaster installation displays "No CSP system 
                            installed" twice when no CSP
                 Bugster:   6717816, 6722652, 6722805, 6722806, 6717891, 6722925
                 Review:    AP

2 Conforms to specification

2 [x] yes
2 [ ] no - comment:


3 Documentation

3.1 user/admin guide OK, or doc CR filed?
3.1 [] yes
3.1 [x] no - comment: not yet documented

3.2 man pages (user view) correct?
3.2 [] yes
3.2 [x] no - comment: not documented

3.3 -help output correct and complete?
3.3 [x] yes
3.3 [] no - comment:

3.4 documented interfaces (at least GDI, EVI, libs, ADOC format) correct, updated?
3.4 [x] yes
3.4 [ ] no - comment:

3.5 messages, output formats and defines OK?
3.5 [x] yes
3.5 [ ] no - comment:

3.6 Bugster CR complete and correct?
3.6 [x] yes
3.6 [ ] no - comment:

3.7 Issuezilla entry (if exists) complete and correct?
3.7 [] yes
3.7 [x] no - comment: Missing many issuezilla entries


4 Source review

4.1 Style guide conformance
4.1 [x] yes
4.1 [ ] no - comment:

4.2 Memory leaks
4.2 [] yes
4.2 [x ] no - comment:
   

4.3 Thread safe
4.3 [x] yes
4.3 [ ] no


5 Tests

5.1 Used memory leak debugger
5.1 [ ] yes
5.1 [x] no - comment: n/a

5.2 Manual tests
Description:
Successfull execution
5.2 [x ] yes
5.2 [] no - comment: 

5.3 Testsuite covers issue
5.3 [] yes
5.3 [x] no - comment: Testsuite does not test upgrade yet

5.4 If 5.3 = no: New testsuite test or module test created?
5.4 [] yes, path: 
5.4 [x] no - justification: Aja works on it
   Manually tested

5.5 If 5.4 = no: Testsuite issue created?
5.5 [ ] yes, id: 
5.5 [x] no - justification:

5.6 Testsuite run successfull
5.6 [ ] yes
5.6 [x] no - comment:
   Only basic intstall/upgrade scenarios.

6 Comments


7 Accepted
7 [x] yes
7 [ ] no - comment: