Source Code Review Form 
=======================
(version 1.3)

Date: 2008-03-20

1 Identification
LP-2008-03-20-0: Bugfix:    svcadm restart does not restart qmaster/shadowd 
                            services
                 Bugfix:    SMF execd does not corretly shutdown on kill -15
                 Bugfix:    SMF execd might not go to disabled state if sge 
                            admin user does not have smf auths
                 Bugtraq:   6677918, 6675579, 6675693
                 Review:    HP, PJ

2 Conforms to specification

2 [x] yes
2 [ ] no - comment:


3 Documentation

3.1 user/admin guide OK, or doc CR filed?
3.1 [] yes
3.1 [x] no - comment: SMF is not yet documented

3.2 man pages (user view) correct?
3.2 [] yes
3.2 [x] no - comment: SMF behavior is not documented

3.3 -help output correct and complete?
3.3 [x] yes
3.3 [ ] no - comment:

3.4 documented interfaces (at least GDI, EVI, libs, ADOC format) correct, updated?
3.4 [x] yes
3.4 [ ] no - comment:

3.5 messages, output formats and defines OK?
3.5 [x] yes
3.5 [ ] no - comment:

3.6 Bugster CR complete and correct?
3.6 [x] yes
3.6 [ ] no - comment:

3.7 Issuezilla entry (if exists) complete and correct?
3.7 [] yes
3.7 [X] no - comment: Bugs that were not yet released (6.2aplha)


4 Source review

4.1 Style guide conformance
4.1 [x] yes
4.1 [ ] no - comment:

4.2 Memory leaks
4.2 [] yes
4.2 [x ] no - comment:
   

4.3 Thread safe
4.3 [x] yes
4.3 [ ] no


5 Tests

5.1 Used memory leak debugger
5.1 [ ] yes
5.1 [x] no - comment: n/a

5.2 Manual tests
Description:
Successfull execution
5.2 [x ] yes
5.2 [] no - comment: 

5.3 Testsuite covers issue
5.3 [x] yes
5.3 [] no - comment:

5.4 If 5.3 = no: New testsuite test or module test created?
5.4 [x ] yes, path: checktree/functional/smf/check.62.exp
5.4 [] no - justification:
   Manually checked output

5.5 If 5.4 = no: Testsuite issue created?
5.5 [ ] yes, id: 
5.5 [x] no - justification:
   Tests created without testsuite issue

5.6 Testsuite run successfull
5.6 [ ] yes
5.6 [x] no - comment:
   Only SMF tests.

6 Comments


7 Accepted
7 [x] yes
7 [ ] no - comment: