Source Code Review Form 
=======================
(version 1.3)

Date: 2007-10-30

1 Identification
JG-2007-10-30-0: Bugfix:    qrsh -no now set all queues in error state when the
                            qrsh was unavailable when the job was scheduled.
                 Bugster:   6588743
                 Issue:     2418
                 Review:    HP, EB


2 Conforms to specification

2 [x] yes
2 [ ] no - comment:


3 Documentation

3.1 user/admin guide OK, or doc CR filed?
3.1 [x] yes
3.1 [ ] no - comment:

3.2 man pages (user view) correct?
3.2 [x] yes
3.2 [ ] no - comment:

3.3 -help output correct and complete?
3.3 [x] yes
3.3 [ ] no - comment:

3.4 documented interfaces (at least GDI, EVI, libs, ADOC format) correct, updated?
3.4 [x] yes
3.4 [ ] no - comment:

3.5 messages, output formats and defines OK?
3.5 [x] yes
3.5 [ ] no - comment:

3.6 Bugster CR complete and correct?
3.6 [x] yes
3.6 [ ] no - comment:

3.7 Issuezilla entry (if exists) complete and correct?
3.7 [x] yes
3.7 [ ] no - comment:


4 Source review

4.1 Style guide conformance
4.1 [x] yes
4.1 [ ] no - comment:

4.2 Memory leaks
4.2 [x] yes
4.2 [ ] no - comment:

4.3 Thread safe
4.3 [x] yes
4.3 [ ] no - comment: 


5 Tests

5.1 Used memory leak debugger
5.1 [ ] yes
5.1 [x] no - comment: n/a

5.2 Manual tests
Description:
- disable all queues
- submit a qrsh job with -now no: qrsh -now no $SGE_ROOT/examples/jobs/sleeper.sh
- kill -9 the qrsh
- enable all queues

Without the fix, we see one queue after the other going into error state, the job 
being rescheduled over and over again.
qacct shows 
failed       11  : before job

With the fix, the job vanishes, no queue is in error state.
qacct shows
failed       19  : before writing exit_status

Ran testsuite tests (qrsh, tight_integration) to make sure nothing else
got broken.

Test successfull:
5.2 [x] yes
5.2 [ ] no - comment:

5.3 Testsuite covers issue
5.3 [ ] yes
5.3 [x] no - comment:

5.4 If 5.3 = no: New testsuite test or module test created?
5.4 [ ] yes, path:
5.4 [x] no - justification: Created testsuite issue.
                            Test will be written in 6.1u3 QA phase.

5.5 If 5.4 = no: Testsuite issue created?
5.5 [x] yes, id: 154
5.5 [ ] no - justification:

5.6 Testsuite run successfull
5.6 [x] yes
5.6 [ ] no - comment:


6 Comments

7 Accepted
7 [x] yes
7 [ ] no - comment: