Source Code Review Form 
=======================
(version 1.2)

Date:

1 Identification
HP-2006-12-01-0: Bugfix:    o "Failed Windows GUI jobs are reported as finished
                               successfully" - both exit code of job and
                               job state in SGE_Helper_Service are now returned
                               to shepherd and mapped to a shepherd state there.
                 changed:   SGE_Helper_Service, shepherd, execd, wingridlib
                 Bugster:   6464927
                 Review:    MD

and

HP-2006-12-01-0: Enhancem.: Enhanced error handling for Windows GUI jobs
                 Changed:   shepherd, execd
                 Review:    MD



2 Conformance to specification

2 [x] yes
2 [ ] no - comment:


3 Documentation

3.1 user/admin guide
3.1 [x] yes
3.1 [ ] no - comment:

3.2 man pages (user view)
3.2 [x] yes
3.2 [ ] no - comment:

3.3 -help output
3.3 [x] yes
3.3 [ ] no - comment:

3.4 documented interfaces (at least GDI, EVI, libs, ADOC format)
3.4 [x] yes
3.4 [ ] no - comment:

3.5 messages, output formats
3.5 [x] yes
3.5 [ ] no - comment:

3.6 Bugster CR
3.6 [ ] yes
3.6 [x] no - comment: Testsuite test still TBD

3.7 Issuezilla
3.7 [ ] yes
3.7 [x] no - comment: Windows bugs have no Issuezilla entry


4 Source review

4.1 Style guide conformance
4.1 [x] yes - at least the changes
4.1 [ ] no - comment:

4.2 Memory leaks
4.2 [ ] yes
4.2 [x] no - comment: no memory debugger for Windows available

4.3 Thread safe
4.3 [x] yes
4.3 [ ] no


5 Tests

5.1 flawfinder diff
No new flaws.
5.1 [ ] yes
5.1 [x] no - no flawfinder on Windows

5.2 Used memory leak debugger
5.2 [ ] yes
5.2 [x] no - comment: On Windows not available

5.3 Manual tests
Description:
Successfull execution
5.3 [x] yes
5.3 [ ] no - comment:

5.4 Testsuite covers issue
5.4 [ ] yes
5.4 [x] no - comment: TBD, current Testsuite problems are prohibiting this.

5.5 If 5.4 = no: Testsuite issue created
5.5 [ ] yes
5.5 [x] no - comment: On my ToDo-List for 6.0u10 patch and already started

5.6 Testsuite run successfull
5.6 [ ] yes
5.6 [x] no - comment: Not yet existing.


6 Comments


7 Accepted
7 [x] yes
7 [ ] no - comment: