Source Code Review Form 
=======================
(version 1.2)

Date: Sep 05 2005

1 Identification
Rewrite of Flex parser for qconf
6319228 - Backslash line continuation is broken for host groups

2 Conformance to specification

2 [X] yes
2 [ ] no - comment:


3 Documentation

3.1 user/admin guide
3.1 [X] yes
3.1 [ ] no - comment:

3.2 man pages (user view)
3.2 [X] yes
3.2 [ ] no - comment:

3.3 -help output
3.3 [X] yes
3.3 [ ] no - comment:

3.4 documented interfaces (at least GDI, EVI, libs, ADOC format)
3.4 [X] yes
3.4 [ ] no - comment:

3.5 messages, output formats
3.5 [X] yes
3.5 [ ] no - comment:

3.6 Bugster CR and Issuezilla
3.6 [X] yes
3.6 [ ] no - comment:

3.7 Issuezilla
3.7 [X] yes
3.7 [ ] no - comment:


4 Source review

4.1 Style guide conformance
4.1 [X] yes
4.1 [ ] no - comment:

4.2 Memory leaks
4.2 [X] yes
4.2 [ ] no - comment:

4.3 Thread safe
4.3 [ ] yes
4.3 [X] no - comment: Flex parsers are not thread safe


5 Tests

5.1 flawfinder diff
No new flaws.
5.1 [ ] yes
5.1 [ ] no - comment: flawfinder doesn't work for Flex

5.2 Used memory leak debugger
5.2 [X] yes
5.2 [ ] no - comment:

5.3 Manual tests
Description: Used qconf with a variety of forms of backslash line continuation
Successfull execution
5.3 [X] yes
5.3 [ ] no - comment:

5.4 Testsuite covers issue
5.4 [X] yes
5.4 [ ] no - comment:

5.5 If 5.4 = no: Testsuite issue created
5.5 [ ] yes
5.5 [ ] no - comment:

5.6 Testsuite run successfull
5.6 [X] yes
5.6 [ ] no - comment:


6 Comments
There is one issue that the rewrite doesn't fix, but I don't see a reasonable
way to fix it, and it is a very minor issue.  If the last line of a file ends
in a backslash, an error message will be printed which says that the last field
has no value.  It's a quirk of Flex, and I don't see a way around it.

7 Accepted
7 [X] yes
7 [ ] no - comment: