Source Code Review Form 
=======================
(version 1.3)

Date:

1 Identification

AH-2007-07-11-0: Bugfix:    Various improvements with sequential assigments and
                            reservation:
                            - kicked out per queue instance soft violation caching
                            - cache operation results and static host matching right
                              after CQ matching
                            - added per host -q evaluation
                            - stop iterating through queue instances when a soft/
                              reservation solution is determined that won't become better
                            - once a soft/reservation solution is found, queue
                              instances no longer are investigated further, as
                              soon as it becomes apparent no better soft/reservation
                              solution will jump out
                            - do RQS shadowing also for reservation jobs if they
                              hinder better solution than already found
                            - do host/cqueue exclusion with RQS shadowing also when
                              host and cqueue shadows global limit rule
                 Bugster:   6579232
                 Issue:     2328
                 Review:    AA

2 Conforms to specification

2 [x] yes
2 [ ] no - comment:


3 Documentation

3.1 user/admin guide OK, or doc CR filed?
3.1 [x] yes
3.1 [ ] no - comment:

3.2 man pages (user view) correct?
3.2 [x] yes
3.2 [ ] no - comment:

3.3 -help output correct and complete?
3.3 [x] yes
3.3 [ ] no - comment:

3.4 documented interfaces (at least GDI, EVI, libs, ADOC format) correct, updated?
3.4 [x] yes
3.4 [ ] no - comment:

3.5 messages, output formats and defines OK?
3.5 [x] yes
3.5 [ ] no - comment:

3.6 Bugster CR complete and correct?
3.6 [x] yes
3.6 [ ] no - comment:

3.7 Issuezilla entry (if exists) complete and correct?
3.7 [x] yes
3.7 [ ] no - comment:


4 Source review

4.1 Style guide conformance
4.1 [x] yes
4.1 [ ] no - comment:

4.2 Memory leaks
4.2 [x] yes
4.2 [ ] no - comment:

4.3 Thread safe
4.3 [x] yes
4.3 [ ] no


5 Tests

5.1 Used memory leak debugger
5.1 [x] yes
5.1 [ ] no - comment:

5.2 Manual tests
Description:
Successfull execution
5.2 [x] yes
5.2 [ ] no - comment:

5.3 Testsuite covers issue
5.3 [ ] yes
5.3 [x] no - comment:

5.4 If 5.3 = no: New testsuite test or module test created?
5.4 [ ] yes, path: 
5.4 [x] no - justification:

5.5 If 5.4 = no: Testsuite issue created?
5.5 [ ] yes, id: 
5.5 [x] no - justification:

5.6 Testsuite run successfull
5.6 [ ] yes
5.6 [x] no - comment: Did extensive manual tests with soft/reservation jobs

https://n1wiki.sfbay.sun.com/bin/view/GE/CutTree
https://n1wiki.sfbay.sun.com/bin/view/GE/ResourceQuotaStaticHostSoft

6 Comments


7 Accepted
7 [x] yes
7 [ ] no - comment: