Source Code Review Form 
=======================
(version 1.2)

Date: 2007-03-29

1 Identification

AH-2007-03-29-0: Bugfix:    Resource quotas broken after qmaster restart
                 Bugster:   6539792
                 Issue:     2224
                 Review:    RD

2 Conformance to specification

2 [x] yes
2 [ ] no - comment:


3 Documentation

3.1 user/admin guide
3.1 [x] yes
3.1 [ ] no - comment:

3.2 man pages (user view)
3.2 [x] yes
3.2 [ ] no - comment:

3.3 -help output
3.3 [x] yes
3.3 [ ] no - comment:

3.4 documented interfaces (at least GDI, EVI, libs, ADOC format)
3.4 [x] yes
3.4 [ ] no - comment:

3.5 messages, output formats
3.5 [x] yes
3.5 [ ] no - comment:

3.6 Bugster CR and Issuezilla
3.6 [x] yes
3.6 [ ] no - comment:

3.7 Issuezilla
3.7 [x] yes
3.7 [ ] no - comment:


4 Source review

4.1 Style guide conformance
4.1 [x] yes
4.1 [ ] no - comment:

4.2 Memory leaks
4.2 [x] yes
4.2 [ ] no - comment: 

4.3 Thread safe
4.3 [x] yes
4.3 [ ] no


5 Tests

5.1 flawfinder diff
No new flaws.
5.1 [ ] yes
5.1 [x] no

5.2 Used memory leak debugger
5.2 [ ] yes
5.2 [x] no - comment: NA

5.3 Manual tests
Configure a resource quota set-up as described in the CR. Without the fix Grid Engine
let only 10 jobs run concurrently after qmaster restart. With the fix 50 jobs run
concurrently. Fix verification can be done also by checking the category string contained
in the accounting(5) file. If accounting entries written after qmaster restart contain 
no -P <project> specification even though a project-based resource quote set was 
configured this is a proof for the bug.

5.3 [x] yes
5.3 [ ] no - comment:

5.4 Testsuite covers issue
5.4 [ ] yes
5.4 [x] no - comment: Created testsuite issue #2225

5.5 If 5.4 = no: Testsuite issue created
5.5 [x] yes
5.5 [ ] no - comment:

5.6 Testsuite run successfull
5.6 [ ] yes
5.6 [x] no - comment: Covered by manual tests.

6 Comments

7 Accepted
7 [x] yes
7 [ ] no - comment: