Source Code Review Form 
=======================
(version 1.2)

Date: 2006-10-25

1 Identification

AH-2006-10-26-0: Bugfix:    qmaster loggings "scheduler tried to remove a
                            incomplete" and "scheduler send a order for a
                            changed user/project"
                 Bugster:   6486125
                 Issue:     2108
                 Review:    JG

2 Conformance to specification

2 [x] yes
2 [ ] no - comment:


3 Documentation

3.1 user/admin guide
3.1 [x] yes
3.1 [ ] no - comment:

3.2 man pages (user view)
3.2 [x] yes
3.2 [ ] no - comment:

3.3 -help output
3.3 [x] yes
3.3 [ ] no - comment:

3.4 documented interfaces (at least GDI, EVI, libs, ADOC format)
3.4 [x] yes
3.4 [ ] no - comment:

3.5 messages, output formats
3.5 [x] yes
3.5 [ ] no - comment:

3.6 Bugster CR and Issuezilla
3.6 [x] yes
3.6 [ ] no - comment:

3.7 Issuezilla
3.7 [x] yes
3.7 [ ] no - comment:


4 Source review

4.1 Style guide conformance
4.1 [x] yes
4.1 [ ] no - comment:

4.2 Memory leaks
4.2 [ ] yes
4.2 [x] no - comment: NA

4.3 Thread safe
4.3 [x] yes
4.3 [ ] no


5 Tests

5.1 flawfinder diff
No new flaws.
5.1 [ ] yes
5.1 [x] no

5.2 Used memory leak debugger
5.2 [x] yes
5.2 [ ] no - comment: NA

5.3 Manual tests
Description: Use 8 execd's each with 20 slots, a qmaster with classic spooling 
over NFS, and 1 second for schedule interval. Then submit a larger array job 
such as "qsub -t 1-2600 $SGE_ROOT/examples/jobs/sleeper.sh 1"
and observe qmaster messages file and watch out for loggings in question.
Another test manually performed was the use of a large scheduling interval 
larger than the time it took qmaster to do all spooling operations upon order 
processing (180 seconds). 
To further verify the correctness of the change a manual test was performed
where sgemaster -migrate was issued on host B after former qmaster on host 
A was shutdown. The test showed that sge_schedd on host A still does finish 
as expected after host B qmaster took over.
Successfull execution
5.3 [x] yes
5.3 [ ] no - comment:

5.4 Testsuite covers issue
5.4 [ ] yes
5.4 [x] no - comment: Required tests are quite comprehensive.

5.5 If 5.4 = no: Testsuite issue created
5.5 [ ] yes
5.5 [x] no - comment:

5.6 Testsuite run successfull
5.6 [ ] yes
5.6 [x] no - comment:

6 Comments

7 Accepted
7 [x] yes
7 [ ] no - comment: